linux-kernel - Re: [PATCH] dmaengine: of-dma: router_xlate to return -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQEDUkY3BHV2OqRR@matsya>
Date:   Wed, 28 Jul 2021 12:42:18 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Peter Ujfalusi <peter.ujfalusi@...il.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, tony@...mide.com, nm@...com
Subject: Re: [PATCH] dmaengine: of-dma: router_xlate to return -EPROBE_DEFER
 if controller is not yet available

On 17-07-21, 22:00, Peter Ujfalusi wrote:
> If the router_xlate can not find the controller in the available DMA
> devices then it should return with -EPORBE_DEFER in a same way as the
> of_dma_request_slave_channel() does.
> 
> The issue can be reproduced if the event router is registered before the
> DMA controller itself and a driver would request for a channel before the
> controller is registered.
> In of_dma_request_slave_channel():
> 1. of_dma_find_controller() would find the dma_router
> 2. ofdma->of_dma_xlate() would fail and returned NULL
> 3. -ENODEV is returned as error code
> 
> with this patch we would return in this case the correct -EPROBE_DEFER and
> the client can try to request the channel later.

Applied, thanks

-- 
~Vinod