linux-kernel - Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210728074605.pp5rs4c65tofnqot@viti.kaiser.cx>
Date:   Wed, 28 Jul 2021 09:46:05 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        dan.carpenter@...cle.com, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, fabioaiuto83@...il.com
Subject: Re: [PATCH v4 0/6] staging: r8188eu: add newer/better RTL8188eu
 driver

Hi Philipp and all,

Thus wrote Phillip Potter (phil@...lpotter.co.uk):

> The driver currently in staging is older and less functional than the
> version on Larry Finger's GitHub account, based upon v4.1.4_6773.20130222.
> This series of patches therefore:

[...]

> V4: don't remove old driver now, just mark as deprecated and modify to
>     allow building alongside the new driver.

Basically, you're suggesting to put aside all the fixes and cleanup
that was done since the rtl8188eu driver was imported into the kernel
tree. The TODO file says

- merge Realtek's bugfixes and new features into the driver

Why aren't we going down this route?

Edimax offer a realtek driver linux_v5.7.6.1_36803.20200602 for
rtl8188eu as a .zip file for download on their website

https://www.edimax.com/edimax/mw/cufiles/files/download/Driver_Utility/EW-7811Un_V2/EW-7811Un_V2_Linux_Driver_1.0.1.2.zip

If we integrate and fix the v4.1.4_6773.20130222 driver, are we running
the risk that someone else will come along and propose another replacement?

Thanks,
Martin