linux-kernel - Re: renesas/master bisection: baseline-nfs.bootrr.rockchip-usb2phy0-probed on rk3399-gru-kevin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fc2b898-434c-3288-2052-70b1e1427b39@collabora.com>
Date:   Wed, 28 Jul 2021 09:48:02 +0100
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     kernelci-results@...ups.io, Johan Jonker <jbx6244@...il.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Maciej Matuszczyk <maccraft123mc@...il.com>,
        Marc Zyngier <maz@...nel.org>,
        Jacob Chen <jacob2.chen@...k-chips.com>,
        Sandy Huang <hjc@...k-chips.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Cameron Nemo <cnemo@...anota.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Elaine Zhang <zhangqing@...k-chips.com>,
        Helen Koike <helen.koike@...labora.com>,
        Robin Murphy <robin.murphy@....com>,
        Shunqian Zheng <zhengsq@...k-chips.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Rob Herring <robh+dt@...nel.org>,
        Yifeng Zhao <yifeng.zhao@...k-chips.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Collabora Kernel ML <kernel@...labora.com>
Subject: Re: renesas/master bisection:
 baseline-nfs.bootrr.rockchip-usb2phy0-probed on rk3399-gru-kevin

On 28/07/2021 09:17, Geert Uytterhoeven wrote:
> Hi Guillaume et al,
> 
> On Wed, Jul 28, 2021 at 8:05 AM Guillaume Tucker
> <guillaume.tucker@...labora.com> wrote:
>> Please see the bisection report below about usb2phy failing to
>> probe on rk3399-gru-kevin.
>>
>> Reports aren't automatically sent to the public while we're
>> trialing new bisection features on kernelci.org but this one
>> looks valid.
> 
> Thanks for your report!
> 
>> The bisection was run in the Renesas tree but the same regression
>> is present in mainline for both usb2phy0 and usb2phy1 devices:
> 
> Exactly, the faulty commit is part of v5.14-rc1.
> 
>>> Breaking commit found:
>>>
>>> -------------------------------------------------------------------------------
>>> commit 8c3d64251ac5c5a3d10364f6b07d3603ac1e7b4a
>>> Author: Johan Jonker <jbx6244@...il.com>
>>> Date:   Tue Jun 1 18:47:59 2021 +0200
>>>
>>>     arm64: dts: rockchip: rename nodename for phy-rockchip-inno-usb2
> 
> P.S. KernelCI is sending lots of reports to linux-reneas-soc[1] for
>      (a) issues on non-Renesas platforms[2], and

One thing to distinguish here is that changes in a tree like the
Renesas one might actually break other platforms, even if it
seems unlikely.  But the improvement explained below addresses
this issue.

>      (b) issues not originating in the renesas-devel tree, like this one.

That is just because I found the bisection report from the
Renesas tree before getting one from mainline.  As we're manually
triaging reports, I mentioned it in my email.  And you're right,
we would need to take this into account before having all the
bisection reports sent automatically.

> Suggestions for improvement:
>   1. If a regression is detected in an upstream tree, there is no
>      need to report it for downstream trees, unless it affects
>      the downstream tree, or originated there.

That's right, we're working on an improvement to be able to
detect "2nd order" regressions, that is to say new failures in a
branch relatively to new failures in an upstream branch.  That
would be typically mainline or stable, but sometimes a subsystem
specific one.

>   2. If a regression is detected for a platform, there is no need
>      to report it for different platform trees, unless it originated
>      there.
> 
> BTW, I do look at the reports for Renesas platforms, but usually I
> don't see what's wrong, and the same platform works fine locally.

Until this has been improved, maybe we can just stop sending
email reports to linux-reneas-soc if they're mostly noise.  The
bisections will still run and reports like this one are sent to
the people and lists who are related to the changes in the patch
rather than the git tree so it's always relevant to them.

> Note that yesterday and today I get "Error while loading data from the
> server (error code: 500). Please contact the website administrator".

Yes that's because the Mongo DB service keeps crashing.  It's a
sysadmin issue that should hopefully get resolved soon, sorry for
the inconvenience.


Thanks for your feedback.

Best wishes,
Guillaume

> [1] https://lore.kernel.org/linux-renesas-soc/?q=kernelci.org
> [2] https://lore.kernel.org/linux-renesas-soc/60ff86ff.1c69fb81.dfe6f.6a7c@mx.google.com/