linux-kernel - Re: [PATCH] locking/atomic: simplify non-atomic wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQEirdfntQMUlpug@hirez.programming.kicks-ass.net>
Date:   Wed, 28 Jul 2021 11:26:05 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-kernel@...r.kernel.org, elver@...gle.com
Subject: Re: [PATCH] locking/atomic: simplify non-atomic wrappers

On Wed, Jul 21, 2021 at 04:58:13PM +0100, Mark Rutland wrote:
> Since the non-atomic arch_*() bitops use plain accesses, they are
> implicitly instrumnted by the compiler, and we work around this in the
> instrumented wrappers to avoid double instrumentation.
> 
> It's simpler to avoid the wrappers entirely, and use the preprocessor to
> alias the arch_*() bitops to their regular versions, removing the need
> for checks in the instrumented wrappers.
> 
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Suggested-by: Marco Elver <elver@...gle.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> ---
>  .../asm-generic/bitops/instrumented-non-atomic.h    | 21 +++++++--------------
>  include/asm-generic/bitops/non-atomic.h             | 16 +++++++---------
>  2 files changed, 14 insertions(+), 23 deletions(-)
> 
> Hi Peter,
> 
> Are you happy to take this atop your queue/locking/core branch?
> 

Will do, thanks!