linux-kernel - Re: [PATCH v2 1/5] HID: magicmouse: register power supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2107281134430.8253@cbobk.fhfr.pm>
Date:   Wed, 28 Jul 2021 11:35:20 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     José Expósito <jose.exposito89@...il.com>
cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] HID: magicmouse: register power supply

On Fri, 25 Jun 2021, José Expósito wrote:

> > > [...]
> > > v2: Add depends on USB_HID to Kconfig
> > 
> > Hmm, why is this dependency needed in the first place, please? I think 
> > trying to keep the drivers independent on transport drivers (especially in 
> > cases like this, where more variants of physical transports actually 
> > really do exist) is worth trying.
> 
> Sorry, that's something I should have explained in the changelog.
> 
> Intel's test bot reported compilation errors on the first version of the patch
> when USB support wasn't configured:
> https://lore.kernel.org/patchwork/patch/1425313/
> 
> I was kindly pointed to a similar error and its fix, but, maybe in this case this
> is not the right fix?
> Maybe there is a macro that I can use to wrap the USB related code in an #ifdef?

It can certainly be wrapped, but looking into the code now, it probably 
wouldn't really bring more clarity. I will apply the series with adding 
the USB_HID dependency for now.

Thanks,

-- 
Jiri Kosina
SUSE Labs