| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <YQEncwVkTGJZCJQu@suse.de>
Date: Wed, 28 Jul 2021 10:46:27 +0100
From: Luis Henriques <lhenriques@...e.de>
To: kernel test robot <lkp@...el.com>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jeff Layton <jlayton@...nel.org>,
Ilya Dryomov <idryomov@...il.com>,
Sasha Levin <sashal@...nel.org>
Subject: Re: [linux-stable-rc:linux-4.9.y 9976/9999] fs/ceph/caps.o: warning:
objtool: handle_cap_grant() falls through to next function
ceph_add_cap.cold()
On Wed, Jul 28, 2021 at 05:13:28AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y
> head: 8da69d43f5d3f7f8787117ee78cfc4060c4c0d29
> commit: 05700fe421866f60f63fbb3a02852425a9bd9447 [9976/9999] libceph: allow ceph_buffer_put() to receive a NULL ceph_buffer
> config: x86_64-randconfig-r021-20210725 (attached as .config)
> compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=05700fe421866f60f63fbb3a02852425a9bd9447
> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> git fetch --no-tags linux-stable-rc linux-4.9.y
> git checkout 05700fe421866f60f63fbb3a02852425a9bd9447
> # save the attached .config to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash LDFLAGS=-z max-page-size=0x200000 arch/x86/xen/ fs/ceph/ net/batman-adv/ net/ceph/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All warnings (new ones prefixed by >>):
>
> In file included from include/linux/ceph/ceph_fs.h:15,
> from include/linux/ceph/types.h:10,
> from include/linux/ceph/libceph.h:18,
> from fs/ceph/super.h:18,
> from fs/ceph/caps.c:11:
> include/linux/ceph/msgr.h:66:1: warning: alignment 1 of 'struct ceph_entity_addr' is less than 8 [-Wpacked-not-aligned]
> 66 | } __attribute__ ((packed));
> | ^
> fs/ceph/caps.c: In function '__send_cap':
> fs/ceph/caps.c:1128:22: warning: variable 'dropping' set but not used [-Wunused-but-set-variable]
> 1128 | int held, revoking, dropping, keep;
> | ^~~~~~~~
> fs/ceph/caps.c: In function 'ceph_handle_caps':
> fs/ceph/caps.c:3571:7: warning: variable 'osd_epoch_barrier' set but not used [-Wunused-but-set-variable]
> 3571 | u32 osd_epoch_barrier;
> | ^~~~~~~~~~~~~~~~~
> fs/ceph/caps.c:3570:19: warning: variable 'caller_gid' set but not used [-Wunused-but-set-variable]
> 3570 | u32 caller_uid, caller_gid;
> | ^~~~~~~~~~
> fs/ceph/caps.c:3570:7: warning: variable 'caller_uid' set but not used [-Wunused-but-set-variable]
> 3570 | u32 caller_uid, caller_gid;
> | ^~~~~~~~~~
> fs/ceph/caps.c:3569:7: warning: variable 'flush_tid' set but not used [-Wunused-but-set-variable]
> 3569 | u64 flush_tid;
> | ^~~~~~~~~
> fs/ceph/caps.o: warning: objtool: handle_cap_flushsnap_ack.constprop.0() falls through to next function __ceph_flush_snaps.cold()
> >> fs/ceph/caps.o: warning: objtool: handle_cap_grant() falls through to next function ceph_add_cap.cold()
I'll be honest: I've no idea why this is happening and x86 assembly isn't my
cup of tea. I wonder, however, why this is showing up now because commit
5c498950f730 has been released in v4.9.192 already.
Cheers,
--
Luís
> --
> In file included from include/linux/ceph/ceph_fs.h:15,
> from include/linux/ceph/types.h:10,
> from include/linux/ceph/libceph.h:18,
> from net/ceph/messenger.c:21:
> include/linux/ceph/msgr.h:66:1: warning: alignment 1 of 'struct ceph_entity_addr' is less than 8 [-Wpacked-not-aligned]
> 66 | } __attribute__ ((packed));
> | ^
> net/ceph/messenger.c: In function 'write_partial_message_data':
> net/ceph/messenger.c:1570:8: warning: variable 'need_crc' set but not used [-Wunused-but-set-variable]
> 1570 | bool need_crc;
> | ^~~~~~~~
> In file included from include/linux/kernel.h:13,
> from include/linux/list.h:8,
> from include/linux/wait.h:6,
> from include/linux/fs.h:5,
> from include/linux/highmem.h:4,
> from net/ceph/messenger.c:5:
> net/ceph/messenger.c: In function 'ceph_sock_state_change':
> include/linux/printk.h:123:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 123 | 0; \
> | ^
> include/linux/printk.h:315:2: note: in expansion of macro 'no_printk'
> 315 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~~~~
> include/linux/ceph/ceph_debug.h:34:25: note: in expansion of macro 'pr_debug'
> 34 | # define dout(fmt, ...) pr_debug(" " fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> net/ceph/messenger.c:431:3: note: in expansion of macro 'dout'
> 431 | dout("%s TCP_CLOSE\n", __func__);
> | ^~~~
> net/ceph/messenger.c:432:2: note: here
> 432 | case TCP_CLOSE_WAIT:
> | ^~~~
> arch/x86/include/asm/bitops.h: Assembler messages:
> arch/x86/include/asm/bitops.h:206: Warning: no instruction mnemonic suffix given and no register operands; using default for `bts'
> arch/x86/include/asm/bitops.h:252: Warning: no instruction mnemonic suffix given and no register operands; using default for `btr'
> >> net/ceph/messenger.o: warning: objtool: ceph_msg_release() falls through to next function ceph_msg_new.cold()
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists