linux-kernel - Re: [PATCH] HID: i2c-hid: goodix: Use the devm variant of regulator_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jul 2021 11:49:10 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: goodix: Use the devm variant of
 regulator_register_notifier()

On Tue, 20 Jul 2021, Douglas Anderson wrote:

> In commit 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset line to
> true state of the regulator") I added a call to
> regulator_register_notifier() but no call to unregister. That's a
> bug. Let's use the devm variant to handle the unregistering.
> 
> Fixes: 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset line to true state of the regulator")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> 
>  drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> index 31a4c229fdb7..52674149a275 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-of-goodix.c
> @@ -132,7 +132,7 @@ static int i2c_hid_of_goodix_probe(struct i2c_client *client,
>  	 */
>  	mutex_lock(&ihid_goodix->regulator_mutex);
>  	ihid_goodix->nb.notifier_call = ihid_goodix_vdd_notify;
> -	ret = regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);
> +	ret = devm_regulator_register_notifier(ihid_goodix->vdd, &ihid_goodix->nb);
>  	if (ret) {
>  		mutex_unlock(&ihid_goodix->regulator_mutex);
>  		return dev_err_probe(&client->dev, ret,

Applied, thanks Doug.

-- 
Jiri Kosina
SUSE Labs