linux-kernel - Re: [PATCH net-next] nfp: flower-ct: fix error return code in nfp_fl_ct_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35c3cfdf-3125-655d-befd-430bd08c9345@corigine.com>
Date:   Wed, 28 Jul 2021 12:08:04 +0200
From:   Louis Peens <louis.peens@...igine.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Yang Yingliang <yangyingliang@...wei.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, simon.horman@...igine.com,
        kuba@...nel.org, davem@...emloft.net, yinjun.zhang@...igine.com
Subject: Re: [PATCH net-next] nfp: flower-ct: fix error return code in
 nfp_fl_ct_add_offload()



On 2021/07/28 11:56, Dan Carpenter wrote:
> On Wed, Jul 28, 2021 at 11:36:43AM +0200, Louis Peens wrote:
>>
>>
>> On 2021/07/28 11:16, Yang Yingliang wrote:
>>> If nfp_tunnel_add_ipv6_off() fails, it should return error code
>>> in nfp_fl_ct_add_offload().
>>>
>>> Fixes: 5a2b93041646 ("nfp: flower-ct: compile match sections of flow_payload")
>>> Reported-by: Hulk Robot <hulkci@...wei.com>
>>> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>> Ah, thanks Yang, I was just preparing a patch for this myself. This was first reported by
>> Dan Carpenter <dan.carpenter@...cle.com> on 26 Jul 2021 (added to CC).
>>
>> 	'Hello Louis Peens,
>>
>> 	The patch 5a2b93041646: "nfp: flower-ct: compile match sections of
>> 	flow_payload" from Jul 22, 2021, leads to the following static
>> 	checker warning:
>> 	.....'
>>
>> I'm not sure what the usual procedure would be for this, I would think adding
>> another "Reported-by" line would be sufficient?'
> 
> Just leave it, it's fine.
> 
>>
>> Anyway, for the patch itself the change looks good to me, thanks:
>> Signed-off-by: Louis Peens <louis.peens@...igine.com>
> 
> Normally it would be Acked-by.  Signed-off-by means you handled the
> patch and it's like signing a legal document that you didn't violate
> SCO copyrights etc.
ack :) Thanks for the clarification, the distinction does confuse me,
thinking about it this way would definitely help.

Regards
Louis Peens
> 
> regards,
> dan carpenter
>