linux-kernel - Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jul 2021 12:01:34 +0100
From:   Dave Stevenson <dave.stevenson@...pberrypi.com>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     DRI Development <dri-devel@...ts.freedesktop.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        bcm-kernel-feedback-list@...adcom.com,
        Daniel Vetter <daniel@...ll.ch>,
        Phil Elwell <phil@...pberrypi.com>,
        Tim Gover <tim.gover@...pberrypi.com>,
        Dom Cobley <dom@...pberrypi.com>,
        Emma Anholt <emma@...olt.net>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rpi-kernel@...ts.infradead.org,
        Maxime Ripard <mripard@...nel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct

On Wed, 7 Jul 2021 at 10:36, Maxime Ripard <maxime@...no.tech> wrote:
>
> Commit 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") removed the
> references to the vc4_hdmi_audio_component_drv structure, but not the
> structure itself resulting in a warning. Remove it.
>
> Fixes: 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Maxime Ripard <maxime@...no.tech>

Reviewed-by: Dave Stevenson <dave.stevenson@...pberrypi.com>

> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 3165f39a4557..1bb06c872175 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -1403,18 +1403,6 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
>         { "TX", NULL, "Playback" },
>  };
>
> -static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
> -       .name                   = "vc4-hdmi-codec-dai-component",
> -       .dapm_widgets           = vc4_hdmi_audio_widgets,
> -       .num_dapm_widgets       = ARRAY_SIZE(vc4_hdmi_audio_widgets),
> -       .dapm_routes            = vc4_hdmi_audio_routes,
> -       .num_dapm_routes        = ARRAY_SIZE(vc4_hdmi_audio_routes),
> -       .idle_bias_on           = 1,
> -       .use_pmdown_time        = 1,
> -       .endianness             = 1,
> -       .non_legacy_dai_naming  = 1,
> -};
> -
>  static const struct snd_soc_component_driver vc4_hdmi_audio_cpu_dai_comp = {
>         .name = "vc4-hdmi-cpu-dai-component",
>  };
> --
> 2.31.1
>