linux-kernel - [linux-chenxing:rperier-rtc 7/7] drivers/rtc/rtc-msc313.c:55:12: error: implicit declaration of function 'readw'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 28 Jul 2021 20:46:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Romain Perier <romain.perier@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [linux-chenxing:rperier-rtc 7/7] drivers/rtc/rtc-msc313.c:55:12:
 error: implicit declaration of function 'readw'

tree:   git://github.com/linux-chenxing/linux.git rperier-rtc
head:   0a94a85f4e6d701c6945740acfb65f65793a5203
commit: 0a94a85f4e6d701c6945740acfb65f65793a5203 [7/7] fix driver
config: sparc-randconfig-r024-20210728 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/linux-chenxing/linux/commit/0a94a85f4e6d701c6945740acfb65f65793a5203
        git remote add linux-chenxing git://github.com/linux-chenxing/linux.git
        git fetch --no-tags linux-chenxing rperier-rtc
        git checkout 0a94a85f4e6d701c6945740acfb65f65793a5203
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/rtc/rtc-msc313.c: In function 'msc313_rtc_read_alarm':
>> drivers/rtc/rtc-msc313.c:55:12: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration]
      55 |  seconds = readw(priv->rtc_base + REG_RTC_MATCH_VAL_L)
         |            ^~~~~
   drivers/rtc/rtc-msc313.c: In function 'msc313_rtc_alarm_irq_enable':
>> drivers/rtc/rtc-msc313.c:76:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration]
      76 |  writew(reg, priv->rtc_base + REG_RTC_CTRL);
         |  ^~~~~~
   cc1: some warnings being treated as errors


vim +/readw +55 drivers/rtc/rtc-msc313.c

88cfefa536ca80e Daniel Palmer 2020-06-12  49  
88cfefa536ca80e Daniel Palmer 2020-06-12  50  static int msc313_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
88cfefa536ca80e Daniel Palmer 2020-06-12  51  {
88cfefa536ca80e Daniel Palmer 2020-06-12  52  	struct msc313_rtc *priv = dev_get_drvdata(dev);
88cfefa536ca80e Daniel Palmer 2020-06-12  53  	unsigned long seconds;
88cfefa536ca80e Daniel Palmer 2020-06-12  54  
88cfefa536ca80e Daniel Palmer 2020-06-12 @55  	seconds = readw(priv->rtc_base + REG_RTC_MATCH_VAL_L)
88cfefa536ca80e Daniel Palmer 2020-06-12  56  			| (readw(priv->rtc_base + REG_RTC_MATCH_VAL_H) << 16);
88cfefa536ca80e Daniel Palmer 2020-06-12  57  
88cfefa536ca80e Daniel Palmer 2020-06-12  58  	rtc_time64_to_tm(seconds, &alarm->time);
88cfefa536ca80e Daniel Palmer 2020-06-12  59  
88cfefa536ca80e Daniel Palmer 2020-06-12  60  	if (!(readw(priv->rtc_base + REG_RTC_CTRL) & INT_MASK_BIT))
88cfefa536ca80e Daniel Palmer 2020-06-12  61  		alarm->enabled = 1;
88cfefa536ca80e Daniel Palmer 2020-06-12  62  
88cfefa536ca80e Daniel Palmer 2020-06-12  63  	return 0;
88cfefa536ca80e Daniel Palmer 2020-06-12  64  }
88cfefa536ca80e Daniel Palmer 2020-06-12  65  
88cfefa536ca80e Daniel Palmer 2020-06-12  66  static int msc313_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
88cfefa536ca80e Daniel Palmer 2020-06-12  67  {
88cfefa536ca80e Daniel Palmer 2020-06-12  68  	struct msc313_rtc *priv = dev_get_drvdata(dev);
88cfefa536ca80e Daniel Palmer 2020-06-12  69  	u16 reg;
88cfefa536ca80e Daniel Palmer 2020-06-12  70  
88cfefa536ca80e Daniel Palmer 2020-06-12  71  	reg = readw(priv->rtc_base + REG_RTC_CTRL);
88cfefa536ca80e Daniel Palmer 2020-06-12  72  	if (enabled)
88cfefa536ca80e Daniel Palmer 2020-06-12  73  		reg &= ~INT_MASK_BIT;
88cfefa536ca80e Daniel Palmer 2020-06-12  74  	else
88cfefa536ca80e Daniel Palmer 2020-06-12  75  		reg |= INT_MASK_BIT;
88cfefa536ca80e Daniel Palmer 2020-06-12 @76  	writew(reg, priv->rtc_base + REG_RTC_CTRL);
88cfefa536ca80e Daniel Palmer 2020-06-12  77  	return 0;
88cfefa536ca80e Daniel Palmer 2020-06-12  78  }
88cfefa536ca80e Daniel Palmer 2020-06-12  79  

:::::: The code at line 55 was first introduced by commit
:::::: 88cfefa536ca80e13ffde033cdc96248e70d3724 rtc: Add support for the MSTAR MSC313 RTC

:::::: TO: Daniel Palmer <daniel@...f.com>
:::::: CC: Romain Perier <romain.perier@...il.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (37600 bytes)