linux-kernel - Re: [PATCH] intersil: remove obsolete prism54 wireless driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmv2fpzj.fsf@codeaurora.org>
Date:   Wed, 28 Jul 2021 17:54:40 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Christian Lamparter <chunkeey@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-wireless@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] intersil: remove obsolete prism54 wireless driver

Luis Chamberlain <mcgrof@...nel.org> writes:

> On Tue, Jul 27, 2021 at 09:07:48AM +0300, Kalle Valo wrote:
>> Christian Lamparter <chunkeey@...il.com> writes:
>> 
>> > On 16/07/2021 00:06, Luis Chamberlain wrote:
>> >> On Tue, Jul 13, 2021 at 07:40:25AM +0200, Lukas Bulwahn wrote:
>> >>> Commit 1d89cae1b47d ("MAINTAINERS: mark prism54 obsolete") indicated the
>> >>> prism54 driver as obsolete in July 2010.
>> >>>
>> >>> Now, after being exposed for ten years to refactoring, general tree-wide
>> >>> changes and various janitor clean-up, it is really time to delete the
>> >>> driver for good.
>> >>>
>> >>> This was discovered as part of a checkpatch evaluation, investigating all
>> >>> reports of checkpatch's WARNING:OBSOLETE check.
>> >>>
>> >>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
>> >>> ---
>> >
>> > noted. Farewell.
>> 
>> How do we know that there are no users left? It's surprising how ancient
>> hardware some people use. Is the driver broken or what?
>> 
>> (Reads commit 1d89cae1b47d)
>> 
>> Ah, p54 is supposed to replace prism54. Does that include all the
>> hardware supported by prism54?
>
> There was a one off chipset someone told me about long ago that p54
> didn't work for. But that persond disappeared from the face of the
> earth. Additionally, distributions have been blacklisting prism54
> for years now.
>
>> If yes, that should be clearly documented
>> in the commit log and I can add that.
>
> Agreed. Feel free to quote the above.

Thanks, will do.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches