linux-kernel - Re: [PATCH] bcm63xx_enet: remove needless variable definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe95911f-b701-f241-c5a2-af8042c9b238@gmail.com>
Date:   Wed, 28 Jul 2021 09:14:53 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Tang Bin <tangbin@...s.chinamobile.com>, davem@...emloft.net,
        kuba@...nel.org, bcm-kernel-feedback-list@...adcom.com
Cc:     netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Zhang Shengju <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] bcm63xx_enet: remove needless variable definitions



On 7/28/2021 6:24 AM, Tang Bin wrote:
> In the function bcm_enetsw_probe(), 'ret' will be assigned by
> bcm_enet_change_mtu(), so 'ret = 0' make no sense.

You are not removing the variable definition or declaration, you are 
removing a redundant assignment which is a different thing. I do agree 
with the rationale however, so please fix up the subject and I will add 
my Acked-by to this patch. Thanks!
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
> ---
>   drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> index 916824cca..509e10013 100644
> --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c
> @@ -2646,7 +2646,6 @@ static int bcm_enetsw_probe(struct platform_device *pdev)
>   	if (!res_mem || irq_rx < 0)
>   		return -ENODEV;
>   
> -	ret = 0;
>   	dev = alloc_etherdev(sizeof(*priv));
>   	if (!dev)
>   		return -ENOMEM;
> 

-- 
Florian