linux-kernel - RE: [RFC PATCH 0/4] TDX KVM selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM8PR11MB567015E199025709764B4FD092EA9@DM8PR11MB5670.namprd11.prod.outlook.com>
Date:   Wed, 28 Jul 2021 04:02:07 +0000
From:   "Duan, Zhenzhong" <zhenzhong.duan@...el.com>
To:     Erdem Aktas <erdemaktas@...gle.com>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
CC:     Paolo Bonzini <pbonzini@...hat.com>, Shuah Khan <shuah@...nel.org>,
        "Andrew Jones" <drjones@...hat.com>,
        Ben Gardon <bgardon@...gle.com>, Peter Xu <peterx@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        "Christian Borntraeger" <borntraeger@...ibm.com>,
        Eric Auger <eric.auger@...hat.com>,
        Emanuele Giuseppe Esposito <eesposit@...hat.com>,
        Ricardo Koller <ricarkol@...gle.com>,
        Aaron Lewis <aaronlewis@...gle.com>,
        Jim Mattson <jmattson@...gle.com>,
        Oliver Upton <oupton@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Peter Shier <pshier@...gle.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Yanan Wang <wangyanan55@...wei.com>,
        "Maciej S. Szmigiero" <maciej.szmigiero@...cle.com>,
        David Matlack <dmatlack@...gle.com>,
        Like Xu <like.xu@...ux.intel.com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:KERNEL VIRTUAL MACHINE (KVM)" <kvm@...r.kernel.org>
Subject: RE: [RFC PATCH 0/4] TDX KVM selftests


> -----Original Message-----
> From: Erdem Aktas <erdemaktas@...gle.com>
> Sent: Tuesday, July 27, 2021 2:38 AM
> To: linux-kselftest@...r.kernel.org
> Cc: erdemaktas@...gle.com; Paolo Bonzini <pbonzini@...hat.com>; Shuah
> Khan <shuah@...nel.org>; Andrew Jones <drjones@...hat.com>; Ben
> Gardon <bgardon@...gle.com>; Peter Xu <peterx@...hat.com>; Sean
> Christopherson <seanjc@...gle.com>; Christian Borntraeger
> <borntraeger@...ibm.com>; Eric Auger <eric.auger@...hat.com>;
> Emanuele Giuseppe Esposito <eesposit@...hat.com>; Ricardo Koller
> <ricarkol@...gle.com>; Duan, Zhenzhong <zhenzhong.duan@...el.com>;
> Aaron Lewis <aaronlewis@...gle.com>; Jim Mattson
> <jmattson@...gle.com>; Oliver Upton <oupton@...gle.com>; Vitaly
> Kuznetsov <vkuznets@...hat.com>; Peter Shier <pshier@...gle.com>; Axel
> Rasmussen <axelrasmussen@...gle.com>; Yanan Wang
> <wangyanan55@...wei.com>; Maciej S. Szmigiero
> <maciej.szmigiero@...cle.com>; David Matlack <dmatlack@...gle.com>;
> Like Xu <like.xu@...ux.intel.com>; open list <linux-kernel@...r.kernel.org>;
> open list:KERNEL VIRTUAL MACHINE (KVM) <kvm@...r.kernel.org>
> Subject: [RFC PATCH 0/4] TDX KVM selftests
> 
> TDX stands for Trust Domain Extensions which isolates VMs from the virtual-
> machine manager (VMM)/hypervisor and any other software on the
> platform.
> 
> Intel has recently submitted a set of RFC patches for KVM support for TDX
> and more information can be found on the latest TDX Support
> Patches: https://lkml.org/lkml/2021/7/2/558
> 
> Due to the nature of the confidential computing environment that TDX
> provides, it is very difficult to verify/test the KVM support. TDX requires UEFI
> and the guest kernel to be enlightened which are all under development.
> 
> We are working on a set of selftests to close this gap and be able to verify the
> KVM functionality to support TDX lifecycle and GHCI [1] interface.
> 
> We are looking for any feedback on:
> - Patch series itself
> - Any suggestion on how we should approach testing TDX functionality.
> Does selftests seems reasonable or should we switch to using KVM unit tests.
> I would be happy to get some perspective on how KVM unit tests can help us
> more.
> - Any test case or scenario that we should add.
> - Anything else I have not thought of yet.
> 
> Current patch series provide the following capabilities:
> 
> - Provide helper functions to create a TD (Trusted Domain) using the KVM
>   ioctls
> - Provide helper functions to create a guest image that can include any
>   testing code
> - Provide helper functions and wrapper functions to write testing code
>   using GHCI interface
> - Add a test case that verifies TDX life cycle
> - Add a test case that verifies TDX GHCI port IO
> 
> TODOs:
> - Use existing function to create page tables dynamically
>   (ie __virt_pg_map())
> - Remove arbitrary defined magic numbers for data structure offsets
> - Add TDVMCALL for error reporting
> - Add additional test cases as some listed below
> - Add #VE handlers to help testing more complicated test cases
> 
> Other test cases that we are planning to add:
> (with credit to sagis@...gle.com)
> 
> VM call interface        Input                        Output                Result
> GetTdVmCallInfo          R12=0                        None                VMCALL_SUCCESS
> MapGPA                   Map private page (GPA.S=0)
> VMCALL_SUCCESS
> MapGPA                   Map shared page (GPA.S=1)
> VMCALL_SUCCESS
> MapGPA                   Map already private page as private
> VMCALL_INVALID_OPERAND
> MapGPA                   Map already shared page as shared
> VMCALL_INVALID_OPERAND
> GetQuote
> ReportFatalError
> SetupEventNotifyInterrupt   Valid interrupt value (32:255)
> VMCALL_SUCCESS
> SetupEventNotifyInterrupt   Invalid value (>255)
> VMCALL_INVALID_OPERAND
> Instruction.CPUID        R12(EAX)=1, R13(ECX)=0       EBX[8:15]=0x8
>                                                       EBX[16:23]=X
>                                                       EBX[24:31]=vcpu_id
>                                                       ECX[0]=1
>                                                       ECX[12]=Y
> Instruction.CPUID       R12(EAX)=1, R13(ECX)=4
> VMCALL_INVALID_OPERAND
> VE.RequestMMIO
> Instruction.HLT                                                           VMCALL_SUCCESS
> Instruction.IO          Read/Write 1/2/4 bytes                            VMCALL_SUCCESS
> Instruction.IO          Read/Write 3 bytes
> VMCALL_INVALID_OPERAND
> Instruction.RDMSR       Accessible register           R11=msr_value
> VMCALL_SUCCESS
>                         Inaccessible register
> VMCALL_INVALID_OPERAND
> Instruction.RDMSR       Accessible register                               VMCALL_SUCCESS
>                         Inaccessible register
> VMCALL_INVALID_OPERAND
> INSTRUCTION.PCONFIG
> 
> [1] Intel TDX Guest-Hypervisor Communication Interface
> 
> https://software.intel.com/content/dam/develop/external/us/en/document
> s/intel-tdx-guest-hypervisor-communication-interface.pdf
> 
> 
> Erdem Aktas (4):
>   KVM: selftests: Add support for creating non-default type VMs
>   KVM: selftest: Add helper functions to create TDX VMs
In tools/testing/selftests/kvm/Makefile, '/lib/x86_64/tdx_lib.c' should be changed to 'lib/x86_64/tdx_lib.c'
After that, build and test passes.

# ./tdx_vm_tests
Verifying TD lifecycle:
Verifying TD IO Exit:
         ... IO WRITE: OK
         ... IO READ: OK
         ... IO verify read/write values: OK

Tested-by: Zhenzhong Duan <zhenzhong.duan@...el.com>

Regards
Zhenzhong