linux-kernel - Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jul 2021 12:42:44 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Bart Van Assche <bvanassche@....org>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     Christoph Hellwig <hch@....de>, Joel Becker <jlbec@...lplan.org>,
        linux-kernel@...r.kernel.org,
        Brendan Higgins <brendanhiggins@...gle.com>,
        David Gow <davidgow@...gle.com>, kunit-dev@...glegroups.com,
        linux-kselftest@...r.kernel.org,
        Bodo Stroesser <bostroesser@...il.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Yanko Kaneti <yaneti@...lera.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 2/3] kunit: Add support for suite initialization and
 cleanup

On 7/29/21 11:16 AM, Bart Van Assche wrote:
> On 7/29/21 9:55 AM, Shuah Khan wrote:
>> On 7/29/21 10:52 AM, Bart Van Assche wrote:
>>> On 7/28/21 10:55 PM, Greg KH wrote:
>>>> On Wed, Jul 28, 2021 at 09:41:24PM -0700, Bart Van Assche wrote:
>>>>> Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>
>>>>> Cc: David Gow <davidgow@...gle.com>
>>>>> Cc: Shuah Khan <skhan@...uxfoundation.org>
>>>>> Cc: kunit-dev@...glegroups.com
>>>>> Cc: linux-kselftest@...r.kernel.org
>>>>> Cc: Bodo Stroesser <bostroesser@...il.com>
>>>>> Cc: Martin K. Petersen <martin.petersen@...cle.com>
>>>>> Cc: Yanko Kaneti <yaneti@...lera.com>
>>>>> Signed-off-by: Bart Van Assche <bvanassche@....org>
>>>>> ---
>>>>
>>>> I know I do not take patches without any changelog text.  Maybe other
>>>> maintainers are more lax :(
>>>
>>> Almost every patch from me has an elaborate changelog. For this patch I chose not to add a changelog since I think that the subject is self-explanatory?
>>
>> I don't take patches without change logs either. I can't say the subject
>> tells me what you are doing.
>>
>> Please add a change log.
> 
> I will add a changelog. But please note that this patch has been sent to Christoph as configfs maintainer.
> 

Sure. This is a kunit patch - hence Kunit maintainers can comment on it.
Besides the comment is about missing change log which is rather basic
kernel dev 101.

Please take a look at Documentation/process/submitting-patches.rst
for information on commit logs.

thanks,
-- Shuah