linux-kernel - Re: [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLNqKOs0WZvBF5L45VZu2OWtjxGyLoMCP-mGA3KbUVxOw@mail.gmail.com>
Date:   Thu, 29 Jul 2021 12:51:42 -0600
From:   Rob Herring <robh@...nel.org>
To:     Yassine Oudjana <y.oudjana@...tonmail.com>
Cc:     Michael Auchter <michael.auchter@...com>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: extcon: usbc-tusb320: Add TUSB320L
 compatible string

On Wed, Jul 28, 2021 at 11:33 AM Yassine Oudjana
<y.oudjana@...tonmail.com> wrote:
>
> On Wednesday, July 28th, 2021 at 9:18 PM, Rob Herring <robh@...nel.org> wrote:
>
> > On Tue, 27 Jul 2021 09:57:15 +0000, Yassine Oudjana wrote:
> >
> > > Add a compatible string for TUSB320L.
> > >
> > > Signed-off-by: Yassine Oudjana y.oudjana@...tonmail.com
> > > -------------------------------------------------------
> > >
> > > .../devicetree/bindings/extcon/extcon-usbc-tusb320.yaml | 4 +++-
> > >
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> >
> > there's no need to repost patches only to add the tags. The upstream
> >
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> I changed indentation in this version to fix a dt_binding_check warning:
> ../Documentation/devicetree/bindings/extcon/extcon-usbc-tusb320.yaml:15:6: [warning] wrong indentation: expected 6 but found 5 (indentation)

That's certainly small enough change to keep any tag.

> I wasn't sure if I had to state changes in each individual patch, so
> I ended up only stating them in the cover letter:
> https://lore.kernel.org/lkml/a1IcsWeSdRxWaMFcwV1k7z3l1HaAkyRCo2zLdOWb8w@cp4-web-014.plabs.ch/

It is best to put the changes for specific patches in that patch and
use the cover letter as a summary of changes.

Rob