linux-kernel - Re: [PATCH 05/12] dt-bindings: pinctrl: update bindings for MT7986 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQMw4zbhxCTqXqLC@robh.at.kernel.org>
Date:   Thu, 29 Jul 2021 16:51:15 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sam Shih <sam.shih@...iatek.com>
Cc:     Sean Wang <sean.wang@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Fabien Parent <fparent@...libre.com>,
        Seiya Wang <seiya.wang@...iatek.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-serial@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-clk@...r.kernel.org, John Crispin <john@...ozen.org>,
        Ryder Lee <Ryder.Lee@...iatek.com>
Subject: Re: [PATCH 05/12] dt-bindings: pinctrl: update bindings for MT7986
 SoC

On Mon, Jul 26, 2021 at 03:14:32PM +0800, Sam Shih wrote:
> This updates bindings for MT7986 pinctrl driver.
> The difference of pinctrl between mt7986a and mt7986b
> is that pin-41 to pin-65 do not exist on mt7986b

Sounds like you could use the same compatible string. Wouldn't the DT 
for mt7986b simply not have any config for those pins?

> 
> Signed-off-by: Sam Shih <sam.shih@...iatek.com>
> ---
>  .../bindings/pinctrl/pinctrl-mt7622.txt       | 284 ++++++++++++++++++
>  1 file changed, 284 insertions(+)

This is a big change. Please convert to a schema. It probably should be 
a separate schema.