linux-kernel - Re: [PATCH] soc: mmsys: mediatek: add mask to mmsys routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97C4FA94-B28A-4F0E-9CD3-4E33B01BA353@fw-web.de>
Date:   Thu, 29 Jul 2021 07:40:30 +0200
From:   Frank Wunderlich <linux@...web.de>
To:     Hsin-Yi Wang <hsinyi@...omium.org>
CC:     "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>, CK Hu <ck.hu@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        lkml <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
        Frank Wunderlich <frank-w@...lic-files.de>
Subject: Re: [PATCH] soc: mmsys: mediatek: add mask to mmsys routes

Am 29. Juli 2021 05:15:23 MESZ schrieb Hsin-Yi Wang <hsinyi@...omium.org>:

>This patch is breaking the mt8183 internal display. I think it's
>because  ~routes[i].val; is removed?
>Also what should the routes[i].mask be if it's not set in
>mmsys_mt8183_routing_table?
>
>>                         writel_relaxed(reg, mmsys->regs +
>routes[i].addr);
>>                 }
>>  }
><snip>

The mask should reset the needed bits,maybe it needs to be adjusted for your ddp components...

Can you add some debugs inside loops in mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect (show read val,mask and final mask before write) to show differences before and after the patch?

regards Frank