linux-kernel - Re: [PATCH] ASoC: samsung: Constify static snd_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f78b45f1-11e8-e1c3-3095-aca32de9fad1@canonical.com>
Date:   Thu, 29 Jul 2021 08:58:54 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: samsung: Constify static snd_soc_ops

On 28/07/2021 19:25, Rikard Falkeborn wrote:
> These are only assigned to the ops field in the snd_soc_dai_link struct
> which is a pointer to const struct snd_soc_ops. Make them const to allow
> the compiler to put them in read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> ---
>  sound/soc/samsung/aries_wm8994.c   | 2 +-
>  sound/soc/samsung/arndale.c        | 4 ++--
>  sound/soc/samsung/h1940_uda1380.c  | 2 +-
>  sound/soc/samsung/littlemill.c     | 2 +-
>  sound/soc/samsung/midas_wm1811.c   | 2 +-
>  sound/soc/samsung/neo1973_wm8753.c | 4 ++--
>  sound/soc/samsung/rx1950_uda1380.c | 2 +-
>  sound/soc/samsung/smartq_wm8987.c  | 2 +-
>  sound/soc/samsung/smdk_wm8580.c    | 2 +-
>  sound/soc/samsung/smdk_wm8994.c    | 2 +-
>  sound/soc/samsung/smdk_wm8994pcm.c | 2 +-
>  sound/soc/samsung/tm2_wm5110.c     | 6 +++---
>  sound/soc/samsung/tobermory.c      | 2 +-
>  13 files changed, 17 insertions(+), 17 deletions(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>


Best regards,
Krzysztof