linux-kernel - Re: [PATCH] tablet: acecad: update the reference count of the usb interface structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210729083139.GS1931@kadam>
Date:   Thu, 29 Jul 2021 11:31:39 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Salah Triki <salah.triki@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Fabio Aiuto <fabioaiuto83@...il.com>,
        Ross Schmidt <ross.schm.dev@...il.com>,
        Marco Cesati <marcocesati@...il.com>,
        Brother Matthew De Angelis <matthew.v.deangelis@...il.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Ivan Safonov <insafonov@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tablet: acecad: update the reference count of the usb
 interface structure

On Thu, Jul 29, 2021 at 01:54:27AM +0100, Salah Triki wrote:
> On Tue, Jul 27, 2021 at 03:37:56PM +0300, Dan Carpenter wrote:
> > This commit message doesn't say what the user visible effects are.  If
> > you encountered this bug at runtime then please put the stack trace in
> > the commit mesage.
> > 
> 
> I made this patch based on the following documentation of
> usb_get_intf():
> 
> [quote]
> Each live reference to a interface must be refcounted.
> 
> Drivers for USB interfaces should normally record such references 
> in their probe methods, when they bind to an interface, and release them 
> by calling usb_put_intf, in their disconnect methods.
> 
> [/quote]

Put that information in the commit message.  Otherwise to review this
patch then I'm trying to look through the syzbot dashboard to find the
stack trace.

regards,
dan carpenter