[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210729085413.GA16945@amd>
Date: Thu, 29 Jul 2021 10:54:13 +0200
From: Pavel Machek <pavel@....cz>
To: Ian Pilcher <arequipeno@...il.com>
Cc: linux-block@...r.kernel.org, linux-leds@...r.kernel.org,
axboe@...nel.dk, linux-kernel@...r.kernel.org,
kernelnewbies@...nelnewbies.org
Subject: Re: [RFC PATCH 0/8] Add configurable block device LED triggers
Hi!
> This patch series adds configurable (i.e. user-defined) block device LED
> triggers.
>
> * Triggers can be created, listed, and deleted via sysfs block class
> attributes (led_trigger_{new,list,del}).
>
> * Once created, block device LED triggers are associated with LEDs just
> like any other LED trigger (via /sys/class/leds/${LED}/trigger).
>
> * Each block device gains a new device attribute (led_trigger) that can
> be used to associate the device with a trigger or clear its
> association.
That's not how this is normally done.
We normally have a trigger ("block device activity") which can then
expose parameters ("I watch for read" and "I monitor sda1").
Is there a reason normal solution can not be used?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists