linux-kernel - Re: [PATCH] TDA1997x: fix tda1997x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1f99432-f11e-fd4d-4956-ae2864f08a2a@xs4all.nl>
Date:   Thu, 29 Jul 2021 11:55:47 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Krzysztof Hałasa <khalasa@...p.pl>,
        Tim Harvey <tharvey@...eworks.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] TDA1997x: fix tda1997x_remove()

On 26/07/2021 12:44, Krzysztof Hałasa wrote:
> TDA1997x I2C "client data" pointer was never set in tda1997x_probe(),
> then the code tried to use invalid pointer in tda1997x_remove().
> 
> Signed-off-by: Krzysztof Hałasa <khalasa@...p.pl>
> 
> diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
> index 71194746c874..043cc8275d00 100644
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -2771,6 +2771,7 @@ static int tda1997x_probe(struct i2c_client *client,
>  		goto err_free_media;
>  	}
>  
> +	i2c_set_clientdata(client, sd);
>  	return 0;
>  
>  err_free_media:
> 

Actually, v4l2_i2c_subdev_init() sets this, and v4l2_i2c_subdev_init() *is* called.
Does it really crash in tda1997x_remove() without this patch?

If so, then I suspect something else is going on.

Regards,

	Hans