linux-kernel - Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKmqyKP8HKERLS3ckOA3wwpiv6J4tdFXn8-d6wXxDXDGn5iN=w@mail.gmail.com>
Date:   Thu, 29 Jul 2021 21:20:14 +1000
From:   Alistair Francis <alistair23@...il.com>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     lgirdwood@...il.com, Mark Brown <broonie@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time

On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@...stair23.me> wrote:
>
> From testing on hardware the poll_enable_time isn't required and
> sometimes causes the driver probe to fail so let's remove it.
>
> Signed-off-by: Alistair Francis <alistair@...stair23.me>

Ping

AlistaIr

> ---
>  drivers/regulator/sy7636a-regulator.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/regulator/sy7636a-regulator.c b/drivers/regulator/sy7636a-regulator.c
> index e021ae08cbaa..c3b34cac8c7f 100644
> --- a/drivers/regulator/sy7636a-regulator.c
> +++ b/drivers/regulator/sy7636a-regulator.c
> @@ -13,8 +13,6 @@
>  #include <linux/gpio/consumer.h>
>  #include <linux/mfd/sy7636a.h>
>
> -#define SY7636A_POLL_ENABLED_TIME 500
> -
>  static int sy7636a_get_vcom_voltage_op(struct regulator_dev *rdev)
>  {
>         int ret;
> @@ -61,7 +59,6 @@ static const struct regulator_desc desc = {
>         .owner = THIS_MODULE,
>         .enable_reg = SY7636A_REG_OPERATION_MODE_CRL,
>         .enable_mask = SY7636A_OPERATION_MODE_CRL_ONOFF,
> -       .poll_enabled_time = SY7636A_POLL_ENABLED_TIME,
>         .regulators_node = of_match_ptr("regulators"),
>         .of_match = of_match_ptr("vcom"),
>  };
> --
> 2.31.1
>