linux-kernel - Re: [PATCH] x86/fault: Fix wrong signal when vsyscall fails with pkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15721c9c-3030-2e4e-8e34-9f18afe8d171@intel.com>
Date:   Thu, 29 Jul 2021 07:02:44 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Jiashuo Liang <liangjs@....edu.cn>
Cc:     bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com,
        linux-kernel@...r.kernel.org, luto@...nel.org, mingo@...hat.com,
        peterz@...radead.org, tglx@...utronix.de, x86@...nel.org
Subject: Re: [PATCH] x86/fault: Fix wrong signal when vsyscall fails with pkey

On 7/28/21 11:24 PM, Jiashuo Liang wrote:
> I agree that using ARCH_DEFAULT_PKEY is better. I think I am supposed to
> send a patch v2 for the update?

Yes, please.

> By the way, the magic pkey number 0 also appears when bad_area_nosemaphore
> calls __bad_area_nosemaphore and bad_area calls __bad_area. Do they need to
> be changed to ARCH_DEFAULT_PKEY as well?

Yes, it would be best to change those as well.  Ideally in a separate patch.