linux-kernel - Re: [PATCH] s390/boot: fix zstd build for -march=z900

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQK+bbDzoqhOngxZ@osiris>
Date:   Thu, 29 Jul 2021 16:42:53 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Vasily Gorbik <gor@...ux.ibm.com>
Cc:     Dimitri John Ledkov <dimitri.ledkov@...onical.com>,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] s390/boot: fix zstd build for -march=z900

On Thu, Jul 29, 2021 at 03:29:19PM +0200, Vasily Gorbik wrote:
> zstd decompression uses __builtin_clz() which fails back to __clzdi2()
> when the kernel is built for older hardware like z900. This leads to
> build failures like the following:
> s390x-11.1.0-ld: /devel/src/kernel/arch/s390/boot/compressed/../../../../lib/zstd/bitstream.h:148: undefined reference to `__clzdi2'
> 
> Fix that by optionally including lib/clz_ctz.c into the decompressor.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 7b034d9c1b08 ("s390/boot: add zstd support")
> Signed-off-by: Vasily Gorbik <gor@...ux.ibm.com>
> ---
>  arch/s390/boot/compressed/Makefile  | 1 +
>  arch/s390/boot/compressed/clz_ctz.c | 2 ++
>  2 files changed, 3 insertions(+)
>  create mode 100644 arch/s390/boot/compressed/clz_ctz.c

Applied, thanks!