linux-kernel - Re: [PATCH] virt: acrn: Do hcall_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210729032211.GA10306@louislifei-OptiPlex-7050>
Date:   Thu, 29 Jul 2021 11:22:11 +0800
From:   Li Fei1 <fei1.li@...el.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, shuox.liu@...il.com,
        reinette.chatre@...el.com, zhi.a.wang@...el.com, yu1.wang@...el.com
Subject: Re: [PATCH] virt: acrn: Do hcall_destroy_vm() before resource release

On Tue, Jul 27, 2021 at 10:47:58PM +0800, Greg Kroah-Hartman wrote:
> On Thu, Jul 22, 2021 at 02:27:36PM +0800, Fei Li wrote:
> > From: Shuo Liu <shuo.a.liu@...el.com>
> >
> > The ACRN hypervisor has scenarios which could run a real-time guest VM.
> > The real-time guest VM occupies dedicated CPU cores, be assigned with
> > dedicated PCI devices. It can run without the Service VM after boot up.
> > hcall_destroy_vm() returns failure when a real-time guest VM refuses.
> > The clearing of flag ACRN_VM_FLAG_DESTROYED causes some kernel resource
> > double-freed in a later acrn_vm_destroy().
> >
> > Do hcall_destroy_vm() before resource release to drop this chance to
> > destroy the VM if hypercall fails.
> >
> > Fixes: 9c5137aedd11 ("virt: acrn: Introduce VM management interfaces")
> > Signed-off-by: Shuo Liu <shuo.a.liu@...el.com>
> > Signed-off-by: Fei Li <fei1.li@...el.com>
> > ---
> 
> Do you also want this backported to older kernels?  If so, you need to
> put a cc: stable in here, right?  I'll go add it myself, but be more
> careful next time please.
yes, thanks for your kind reminder.
I will pay great attention next time.

> 
> greg k-h