linux-kernel - Re: [PATCH] staging: vt665X: remove unused CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68f85669-71a8-b0c9-d23f-0dc7e1de2f12@infradead.org>
Date:   Thu, 29 Jul 2021 07:51:11 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev
Cc:     forest@...ttletooquiet.net, linux-kernel@...r.kernel.org,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] staging: vt665X: remove unused CONFIG_PATH

On 7/29/21 2:58 AM, Greg Kroah-Hartman wrote:
> The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating
> around in the code, but it is never used.  Remove it as drivers should
> never be reading from config files anyway, even if these were valid
> files.
> 
> Reported-by: Joe Perches <joe@...ches.com>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/staging/vt6655/device_cfg.h | 3 ---
>  drivers/staging/vt6656/device.h     | 2 --
>  2 files changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
> index db0304f6e21c..2d647a3619ba 100644
> --- a/drivers/staging/vt6655/device_cfg.h
> +++ b/drivers/staging/vt6655/device_cfg.h
> @@ -38,9 +38,6 @@
>  
>  #include <linux/fs.h>
>  #include <linux/fcntl.h>
> -#ifndef CONFIG_PATH
> -#define CONFIG_PATH            "/etc/vntconfiguration.dat"
> -#endif
>  
>  #define PKT_BUF_SZ          2390
>  
> diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
> index 947530fefe94..2c93a2e66c8a 100644
> --- a/drivers/staging/vt6656/device.h
> +++ b/drivers/staging/vt6656/device.h
> @@ -77,8 +77,6 @@
>  #define FIRMWARE_NAME			"vntwusb.fw"
>  #define FIRMWARE_CHUNK_SIZE		0x400
>  
> -#define CONFIG_PATH			"/etc/vntconfiguration.dat"
> -
>  #define MAX_UINTS			8
>  #define OPTION_DEFAULT			{ [0 ... MAX_UINTS - 1] = -1}
>  
> 


-- 
~Randy