linux-kernel - Re: [PATCH] KVM: SVM: delay svm_vcpu_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38eb919c-2da1-648e-10a4-a76205fd5e96@redhat.com>
Date:   Thu, 29 Jul 2021 18:30:49 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vineeth Pillai <viremana@...ux.microsoft.com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Subject: Re: [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is
 initialized

On 28/07/21 22:18, Vineeth Pillai wrote:
> 
> On 7/27/2021 11:23 AM, Vitaly Kuznetsov wrote:
>> Paolo Bonzini <pbonzini@...hat.com> writes:
>>
>>> Right now, svm_hv_vmcb_dirty_nested_enlightenments has an incorrect
>>> dereference of vmcb->control.reserved_sw before the vmcb is checked
>>> for being non-NULL.  The compiler is usually sinking the dereference
>>> after the check; instead of doing this ourselves in the source,
>>> ensure that svm_hv_vmcb_dirty_nested_enlightenments is only called
>>> with a non-NULL VMCB.
>>>
>>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>>> Cc: Vineeth Pillai <viremana@...ux.microsoft.com>
>>> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
>>> [Untested for now due to issues with my AMD machine. - Paolo]
> Finally got hold of an AMD machine and tested nested virt: windows on 
> linux on
> windows with the patches applied. Did basic boot and minimal verification.
> 
> Tested-by: Vineeth Pillai <viremana@...ux.microsoft.com>

Thanks!  In the meanwhile I had fixed my machine too. :)

Paolo