lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 30 Jul 2021 16:47:57 -0400
From:   Hamza Mahfooz <>
To:     Peter Xu <>
Cc:, Paolo Bonzini <>,
        Sean Christopherson <>,
        Vitaly Kuznetsov <>,
        Wanpeng Li <>,
        Jim Mattson <>,
        Joerg Roedel <>,
        Thomas Gleixner <>,
        Ingo Molnar <>, Borislav Petkov <>,, "H. Peter Anvin" <>,
Subject: Re: [PATCH] KVM: const-ify all relevant uses of struct

Hey Peter,

On Fri, Jul 30 2021 at 04:19:21 PM -0400, Peter Xu <> 
> This patch breaks kvm/queue with above issue.  Constify of 
> kvm_memory_slot
> pointer should have nothing to do with this so at least it should 
> need a
> separate patch.  At the meantime I also don't understand why memcpy() 
> here,
> which seems to be even slower..

To const-ify the slot member of struct slot_rmap_walk_iterator, we need 
initialize a new struct and then copy it over (otherwise we would need 
to relay
on casting again or the compiler will complain about it).

Powered by blists - more mailing lists