linux-kernel - Re: [RESEND PATCH v4] clk: stm32f4: fix post divisor setup for I2S/SAI PLLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1098513125.52015.1627680169782@mail1.libero.it>
Date:   Fri, 30 Jul 2021 23:22:49 +0200 (CEST)
From:   Dario Binacchi <dariobin@...ero.it>
To:     Stephen Boyd <sboyd@...nel.org>, Dillon Hua <dillonhua@...il.com>
Cc:     linux-clk@...r.kernel.org,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Gabriel Fernandez <gabriel.fernandez@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [RESEND PATCH v4] clk: stm32f4: fix post divisor setup for
 I2S/SAI PLLs

Hi Stephen,

> Il 30/07/2021 21:47 Stephen Boyd <sboyd@...nel.org> ha scritto:
> 
>  
> Quoting Dario Binacchi (2021-07-29 03:03:22)
> > Hi Dillon,
> > 
> > > Il 28/07/2021 12:03 Dillon Hua <dillonhua@...il.com> ha scritto:
> > > 
> > >  
> > > Hi Dario,
> > > 
> > > I have a similar patch [1] submitted last year.
> > > Unfortunately, it did not get accepted by the maintainer.
> > > 
> > > Just a reminder here for you, should remove
> > > 
> > > { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
> > 
> > Thank you for your suggestion.
> > While testing the patch on the stm32f469-disco board I didn't
> > notice the white screen issue. I'll try to run the tests again. 
> > I will let you know.
> > 
> 
> Ok, I'll drop this from the tree.

The patch fixes commit 517633ef630e ("clk: stm32f4: Add post divisor for I2S & SAI PLLs"),
so IMHO it should not be dropped from the tree.
What Dillon suggests, if confirmed, should be fixed by another patch.

Thanks and regards,
Dario