linux-kernel - Re: [PATCH] scsi: BusLogic: use %X for u32 sized integer rather than %lX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0d9a73c-3817-ea12-8cda-8970ac849191@gonehiking.org>
Date:   Fri, 30 Jul 2021 15:57:16 -0600
From:   Khalid Aziz <khalid@...ehiking.org>
To:     Colin King <colin.king@...onical.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: BusLogic: use %X for u32 sized integer rather than
 %lX

On 7/30/21 3:50 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> An earlier fix changed the print format specifier for adapter->bios_addr
> to use %lX however the integer is a u32 so the fix was wrong. Fix this
> by using the correct %X format specifier.
> 
> Addresses-Coverity: ("Invalid type in argument")
> Fixes: 43622697117c ("scsi: BusLogic: use %lX for unsigned long rather than %X")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/scsi/BusLogic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index adddcd589941..bd615db5c58c 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -1711,7 +1711,7 @@ static bool __init blogic_reportconfig(struct blogic_adapter *adapter)
>  	if (adapter->adapter_bus_type != BLOGIC_PCI_BUS) {
>  		blogic_info("  DMA Channel: None, ", adapter);
>  		if (adapter->bios_addr > 0)
> -			blogic_info("BIOS Address: 0x%lX, ", adapter,
> +			blogic_info("BIOS Address: 0x%X, ", adapter,
>  					adapter->bios_addr);
>  		else
>  			blogic_info("BIOS Address: None, ", adapter);
> 

Acked-by: Khalid Aziz <khalid@...ehiking.org>