[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1627684090.574176.3442796.nullmailer@robh.at.kernel.org>
Date: Fri, 30 Jul 2021 16:28:10 -0600
From: Rob Herring <robh@...nel.org>
To: Dario Binacchi <dariobin@...ero.it>
Cc: devicetree@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>,
Marc Kleine-Budde <mkl@...gutronix.de>,
linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
linux-can@...r.kernel.org, Wolfgang Grandegger <wg@...ndegger.com>
Subject: Re: [PATCH v3] dt-bindings: net: can: c_can: convert to json-schema
On Fri, 30 Jul 2021 19:16:46 +0200, Dario Binacchi wrote:
> Convert the Bosch C_CAN/D_CAN controller device tree binding
> documentation to json-schema.
>
> Document missing properties.
> Remove "ti,hwmods" as it is no longer used in TI dts.
> Make "clocks" required as it is used in all dts.
> Correct nodename in the example.
>
> Signed-off-by: Dario Binacchi <dariobin@...ero.it>
>
> ---
>
> Changes in v3:
> - Add type (phandle-array) and size (maxItems: 2) to syscon-raminit
> property.
>
> Changes in v2:
> - Drop Documentation references.
>
> .../bindings/net/can/bosch,c_can.yaml | 85 +++++++++++++++++++
> .../devicetree/bindings/net/can/c_can.txt | 65 --------------
> 2 files changed, 85 insertions(+), 65 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/net/can/bosch,c_can.yaml
> delete mode 100644 Documentation/devicetree/bindings/net/can/c_can.txt
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/can/bosch,c_can.example.dt.yaml: can@0: syscon-raminit: [[4294967295, 1604, 1]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/can/bosch,c_can.yaml
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1511753
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
Powered by blists - more mailing lists