lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 30 Jul 2021 23:35:38 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "Hansen, Dave" <dave.hansen@...el.com>
CC:     Sean Christopherson <seanjc@...gle.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>
Subject: RE: [PATCH v3 2/7] x86/sgx: Add infrastructure to identify SGX EPC
 pages

>	xa_store_range(&epc_page_ranges,
>		       section->phys_addr,
>		       section->end_phys_addr, ...);
>
> ... you did it based on PFNs:
>
>	xa_store_range(&epc_page_ranges,
>		       section->phys_addr     >> PAGE_SHIFT,
>		       section->end_phys_addr >> PAGE_SHIFT, ...);
>
> SGX sections are at *least* page-aligned, so this should be fine.

I found xa_dump() (hidden inside #ifdef XA_DEBUG)

Trying both with and without the >> PAGE_SHIFT made no difference
to the number of lines of console output that xa_dump() spits out.
266 either way.

There are only two ranges on this system

[   11.937592] sgx: EPC section 0x8000c00000-0x807f7fffff
[   11.945811] sgx: EPC section 0x10000c00000-0x1007fffffff

So I'm a little bit sad that xarray appears to have broken them up
into a bunch of pieces.

-Tony

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ