[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YQOKz0l6aaU8PGLV@kroah.com>
Date: Fri, 30 Jul 2021 07:14:55 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
kernel@...gutronix.de, linux-pci@...r.kernel.org,
Michael Ellerman <mpe@...erman.id.au>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Russell Currey <ruscur@...sell.cc>,
Oliver O'Halloran <oohall@...il.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...hat.com>,
Namhyung Kim <namhyung@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Borislav Petkov <bp@...en8.de>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>,
Rafał Miłecki <zajec5@...il.com>,
Zhou Wang <wangzhou1@...ilicon.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
Sathya Prakash <sathya.prakash@...adcom.com>,
Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
Suganath Prabu Subramani
<suganath-prabu.subramani@...adcom.com>,
Frederic Barrat <fbarrat@...ux.ibm.com>,
Andrew Donnellan <ajd@...ux.ibm.com>,
Arnd Bergmann <arnd@...db.de>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
Jakub Kicinski <kuba@...nel.org>,
Vadym Kochan <vkochan@...vell.com>,
Taras Chornyi <tchornyi@...vell.com>,
Jiri Pirko <jiri@...dia.com>, Ido Schimmel <idosch@...dia.com>,
Simon Horman <simon.horman@...igine.com>,
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Juergen Gross <jgross@...e.com>,
Stefano Stabellini <sstabellini@...nel.org>,
Michael Buesch <m@...s.ch>,
Mathias Nyman <mathias.nyman@...el.com>,
Fiona Trahe <fiona.trahe@...el.com>,
Andy Shevchenko <andriy.shevchenko@...el.com>,
Wojciech Ziemba <wojciech.ziemba@...el.com>,
Alexander Duyck <alexanderduyck@...com>,
linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org, linux-wireless@...r.kernel.org,
linux-crypto@...r.kernel.org, qat-linux@...el.com,
MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
netdev@...r.kernel.org, oss-drivers@...igine.com,
xen-devel@...ts.xenproject.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v1 0/5] PCI: Drop duplicated tracking of a pci_dev's
bound driver
On Thu, Jul 29, 2021 at 10:37:35PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> struct pci_dev tracks the bound pci driver twice. This series is about
> removing this duplication.
>
> The first two patches are just cleanups. The third patch introduces a
> wrapper that abstracts access to struct pci_dev->driver. In the next
> patch (hopefully) all users are converted to use the new wrapper and
> finally the fifth patch removes the duplication.
>
> Note this series is only build tested (allmodconfig on several
> architectures).
>
> I'm open to restructure this series if this simplifies things. E.g. the
> use of the new wrapper in drivers/pci could be squashed into the patch
> introducing the wrapper. Patch 4 could be split by maintainer tree or
> squashed into patch 3 completely.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (5):
> PCI: Simplify pci_device_remove()
> PCI: Drop useless check from pci_device_probe()
> PCI: Provide wrapper to access a pci_dev's bound driver
> PCI: Adapt all code locations to not use struct pci_dev::driver
> directly
> PCI: Drop duplicated tracking of a pci_dev's bound driver
Other than my objection to patch 5/5 lack of changelog, looks sane to
me:
Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Powered by blists - more mailing lists