linux-kernel - Re: [PATCH v2 1/3] dt-bindings: nvmem: qfprom: Add optional power-domains property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e482bc2-59e0-0d30-aa7e-4e2a2bd594b4@codeaurora.org>
Date:   Fri, 30 Jul 2021 11:27:33 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        "Ravi Kumar Bokka (Temp)" <rbokka@...eaurora.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: nvmem: qfprom: Add optional
 power-domains property


On 7/29/2021 9:49 PM, Doug Anderson wrote:
> Hi,
> 
> On Thu, Jul 29, 2021 at 5:01 AM Rajendra Nayak <rnayak@...eaurora.org> wrote:
>>
>> qfprom devices on some SoCs need to vote on the performance state
>> of a power-domain, so add the power-domains optional property to the
>> bindings
>>
>> Signed-off-by: Rajendra Nayak <rnayak@...eaurora.org>
>> ---
>>   Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
>> index 861b205..a498a08 100644
>> --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
>> +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
>> @@ -51,6 +51,9 @@ properties:
>>     vcc-supply:
>>       description: Our power supply.
>>
>> +  power-domains:
>> +    description: A phandle to a power domain node.
>> +
> 
> I'm trying to channel my inner Rob here by saying that this
> description doesn't add anything and this should just be:

Thanks, I trust the inner Rob in you :), so I'll drop the description
and repost.

> 
> power-domains:
>    maxItems: 1
> 
> Here's an example of Rob saying this:
> 
> https://lore.kernel.org/linux-devicetree/20210712151322.GA1931925@robh.at.kernel.org/
> 
> Other than that, feel free to add my "Reviewed-by" tag.
> 
> -Doug
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation