linux-kernel - Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKmqyKNyvE7wL-sRW7h7LoZJvwpDwMZFvXSLBB9ziz+01fPu1w@mail.gmail.com>
Date:   Fri, 30 Jul 2021 16:11:51 +1000
From:   Alistair Francis <alistair23@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Alistair Francis <alistair@...stair23.me>, lgirdwood@...il.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: sy7636a: Remove the poll_enable_time

On Thu, Jul 29, 2021 at 9:22 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Thu, Jul 29, 2021 at 09:20:14PM +1000, Alistair Francis wrote:
> > On Tue, Jul 6, 2021 at 9:41 PM Alistair Francis <alistair@...stair23.me> wrote:
> > >
> > > From testing on hardware the poll_enable_time isn't required and
> > > sometimes causes the driver probe to fail so let's remove it.
> > >
> > > Signed-off-by: Alistair Francis <alistair@...stair23.me>
> >
> > Ping
>
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.

Sorry, I was following what happens with some other projects and
pinging after a few weeks.

>
> Sending content free pings adds to the mail volume (if they are seen at
> all) which is often the problem and since they can't be reviewed
> directly if something has gone wrong you'll have to resend the patches
> anyway, so sending again is generally a better approach though there are
> some other maintainers who like them - if in doubt look at how patches
> for the subsystem are normally handled.

Ok, in future I'll try to follow what others in the subsystem do.

Alistair