linux-kernel - Re: [PATCH 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a5956b2-f9d6-ce92-a517-37e67da81324@roeck-us.net>
Date:   Thu, 29 Jul 2021 18:14:25 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Rob Herring <robh@...nel.org>
Cc:     Samuel Holland <samuel@...lland.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1

On 7/29/21 3:39 PM, Rob Herring wrote:
> On Wed, Jul 28, 2021 at 09:24:49PM -0700, Guenter Roeck wrote:
>> On Sun, Jul 25, 2021 at 10:51:42PM -0500, Samuel Holland wrote:
>>> D1 keeps the same register layout and clock sources as the R329, but it
>>> adds a key field which must be set to update the watchdog's "CFG" and
>>> "MODE" registers. Therefore it is not backward-compatible.
>>>
>>> Signed-off-by: Samuel Holland <samuel@...lland.org>
>>> ---
>>>   .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml   | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
>>> index 853ceb1b7c0f..756e6ab99860 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
>>> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
>>> @@ -29,6 +29,7 @@ properties:
>>>         - items:
>>>             - const: allwinner,suniv-f1c100s-wdt
>>>             - const: allwinner,sun4i-a10-wdt
>>> +      - const: allwinner,sun20i-d1-wdt
>>
>> Alignment is off.
> 
> No, it's correct. It's not part of the above list, but a new 'oneOf'
> entry.
> 

Ok, I really should not try to review devicetree files.

Thanks,
Guenter