[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a360877260a877819ad8eef7f63c370e0c16c640.camel@pengutronix.de>
Date: Fri, 30 Jul 2021 11:45:50 +0200
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Anand Moon <linux.amoon@...il.com>, netdev@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
devicetree@...r.kernel.org
Cc: Jerome Brunet <jbrunet@...libre.com>,
Neil Armstrong <narmstrong@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Rob Herring <robh+dt@...nel.org>,
Kevin Hilman <khilman@...libre.com>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Emiliano Ingrassia <ingrassia@...genesys.com>
Subject: Re: [PATCHv1 2/3] ARM: dts: meson: Use new reset id for reset
controller
On Fri, 2021-07-30 at 01:40 +0530, Anand Moon wrote:
> Used new reset id for reset controller as it conflict
> with the core reset id.
>
> Fixes: b96446541d83 ("ARM: dts: meson8b: extend ethernet controller description")
>
> Cc: Jerome Brunet <jbrunet@...libre.com>
> Cc: Neil Armstrong <narmstrong@...libre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> Signed-off-by: Anand Moon <linux.amoon@...il.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 2 +-
> arch/arm/boot/dts/meson8m2.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index c02b03cbcdf4..cb3a579d09ef 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -511,7 +511,7 @@ ðmac {
> tx-fifo-depth = <2048>;
>
> resets = <&reset RESET_ETHERNET>;
> - reset-names = "stmmaceth";
> + reset-names = "ethreset";
This looks like an incompatible change. Is the "stmmaceth" reset not
used? It is documented as "MAC reset signal" in [1]. So a PHY reset
should be separate from this.
[1] Documentation/devicetree/bindings/net/snps,dwmac.yaml
regards
Philipp
Powered by blists - more mailing lists