linux-kernel - Re: [PATCH v3, 01/15] media: mtk-vcodec: Get numbers of register bases from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Jul 2021 12:09:35 +0200
From:   Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
To:     Tzung-Bi Shih <tzungbi@...gle.com>,
        Yunfei Dong <Yunfei.Dong@...iatek.com>
Cc:     Alexandre Courbot <acourbot@...omium.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Tzung-Bi Shih <tzungbi@...omium.org>,
        Tiffany Lin <tiffany.lin@...iatek.com>,
        Andrew-CT Chen <andrew-ct.chen@...iatek.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Tomasz Figa <tfiga@...gle.com>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        Fritz Koenig <frkoenig@...omium.org>,
        Irui Wang <irui.wang@...iatek.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        srv_heupstream@...iatek.com, linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v3, 01/15] media: mtk-vcodec: Get numbers of register
 bases from DT



On 30.07.21 11:31, Tzung-Bi Shih wrote:
> On Tue, Jul 27, 2021 at 06:10:37PM +0800, Yunfei Dong wrote:
>> +static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev)
>> +{
>> +     struct platform_device *pdev = dev->plat_dev;
>> +     int reg_num, i, ret = 0;
> ret don't need to be initialized.
> 
>> +     for (i = 0; i < reg_num; i++) {
>> +             dev->reg_base[i] = devm_platform_ioremap_resource(pdev, i);
>> +             if (IS_ERR((__force void *)dev->reg_base[i])) {
>> +                     return PTR_ERR((__force void *)dev->reg_base[i]);
>> +             }
> { } can be removed.

I think that also the "__fore void*" can be removed

thanks,
Dafna

>