linux-kernel - Re: [PATCH] lockdep/selftests: Fix duplicate included locking-selftest-softirq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Jul 2021 18:36:20 +0800
From:   Boqun Feng <boqun.feng@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     peterz@...radead.org, mingo@...hat.com, will@...nel.org,
        longman@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockdep/selftests: Fix duplicate included
 locking-selftest-softirq.h

Hi,

On Fri, Jul 30, 2021 at 06:24:42PM +0800, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
> 
> ./lib/locking-selftest.c: locking-selftest-softirq.h is included more
> than once.
> 

Those inclusions in the file are used as poor man's template, IOW, the
header files redefine some names so that we can use one template to
generate many similar functions.

So no need to fix, thanks! But if you have a better idea to generate
functions, please let me know ;-)

Regards,
Boqun

> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: cae2ed9aa573 ("[PATCH] lockdep: locking API self tests")
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  lib/locking-selftest.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
> index 161108e..6010445 100644
> --- a/lib/locking-selftest.c
> +++ b/lib/locking-selftest.c
> @@ -1252,7 +1252,6 @@ static void rwsem_ABBA3(void)
>  #include "locking-selftest-wlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion2_hard_wlock)
>  
> -#include "locking-selftest-softirq.h"
>  #include "locking-selftest-rlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion2_soft_rlock)
>  
> @@ -1306,7 +1305,6 @@ static void rwsem_ABBA3(void)
>  #include "locking-selftest-wlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion3_hard_wlock)
>  
> -#include "locking-selftest-softirq.h"
>  #include "locking-selftest-rlock.h"
>  GENERATE_PERMUTATIONS_3_EVENTS(irq_read_recursion3_soft_rlock)
>  
> -- 
> 1.8.3.1
>