linux-kernel - Re: [PATCH] bcm63xx_enet: simplify the code in bcm_enet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210730062852.3d41cc52@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 30 Jul 2021 06:28:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Tang Bin <tangbin@...s.chinamobile.com>
Cc:     davem@...emloft.net, bcm-kernel-feedback-list@...adcom.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcm63xx_enet: simplify the code in bcm_enet_open()

On Thu, 29 Jul 2021 14:23:28 -0700 Florian Fainelli wrote:
> On 7/29/21 12:06 AM, Tang Bin wrote:
> > In the function bcm_enet_open(), 'ret = -ENOMEM' can be moved
> > outside the judgement statement, so redundant assignments can
> > be removed to simplify the code.
> > 
> > Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>  
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>

I wouldn't, the existing code is more robust IMO, but your call :)

Does not apply to net-next, please rebase.