linux-kernel - Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd223956-93c8-1fb6-325d-0afb34ad2f23@intel.com>
Date:   Fri, 30 Jul 2021 15:50:48 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Lukasz Majczak <lma@...ihalf.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     upstream@...ihalf.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv_name

On 2021-07-30 1:59 PM, Lukasz Majczak wrote:
> platform_id for kbl_da7219_max98357a was shrunk for kbl_da7219_mx98357a,
> but the drv_name was changed for kbl_da7219_max98373. Tested on a
> Pixelbook (Atlas).

Reasoning behind Pierre's initial commit is valid and I believe 
kbl_da7219_max98373 name change was simply unintended. To make the 
situation clearer, please be more elaborate in commit's message.

> Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters")
> Cc: <stable@...r.kernel.org> # 5.4+
> Reported-by: Cezary Rojewski <cezary.rojewski@...el.com>

Please reword to: Suggested-by. I certainly wasn't the one who found the 
problem first, but I did provide the initial fix.

I don't see any problem is the code, so besides formalities:

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>


Thanks,
Czarek