linux-kernel - Re: [PATCH] RDMA/hfi1: Convert from atomic_t to refcount_t on hfi1_devdata->user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210730140639.GB2559559@nvidia.com>
Date:   Fri, 30 Jul 2021 11:06:39 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>
Cc:     Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, yuanxzhang@...an.edu.cn,
        Xin Tan <tanxin.ctf@...il.com>
Subject: Re: [PATCH] RDMA/hfi1: Convert from atomic_t to refcount_t on
 hfi1_devdata->user_refcount

On Mon, Jul 19, 2021 at 02:00:53PM +0800, Xiyu Yang wrote:
> refcount_t type and corresponding API can protect refcounters from
> accidental underflow and overflow and further use-after-free situations.
> 
> Signed-off-by: Xiyu Yang <xiyuyang19@...an.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@...il.com>
> Tested-by: Josh Fisher <josh.fisher@...nelisnetworks.com>
> Acked-by: Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>
> ---
>  drivers/infiniband/hw/hfi1/chip.c     | 2 +-
>  drivers/infiniband/hw/hfi1/file_ops.c | 6 +++---
>  drivers/infiniband/hw/hfi1/hfi.h      | 3 ++-
>  drivers/infiniband/hw/hfi1/init.c     | 2 +-
>  4 files changed, 7 insertions(+), 6 deletions(-)

Applied to for-next, thanks

Jason