linux-kernel - Re: [PATCH 7/9] phy: phy-mtk-hdmi: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAOTY_95Qpv-RjxzWteQ-+p=P0siC2c0vAQdkx-V7bfCwgn34g@mail.gmail.com>
Date:   Sat, 31 Jul 2021 00:23:09 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc:     Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-phy@...ts.infradead.org, DTML <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Eddie Hung <eddie.hung@...iatek.com>
Subject: Re: [PATCH 7/9] phy: phy-mtk-hdmi: convert to devm_platform_ioremap_resource

Hi, Chunfeng:

Chunfeng Yun <chunfeng.yun@...iatek.com> 於 2021年7月28日 週三 下午3:59寫道：
>
> Use devm_platform_ioremap_resource to simplify code

Acked-by: Chun-Kuang Hu <chunkuang.hu@...nel.org>

>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> ---
>  drivers/phy/mediatek/phy-mtk-hdmi.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c
> index 8ad8f717ef43..5fb4217fb8e0 100644
> --- a/drivers/phy/mediatek/phy-mtk-hdmi.c
> +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c
> @@ -100,7 +100,6 @@ static int mtk_hdmi_phy_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct mtk_hdmi_phy *hdmi_phy;
> -       struct resource *mem;
>         struct clk *ref_clk;
>         const char *ref_clk_name;
>         struct clk_init_data clk_init = {
> @@ -116,11 +115,9 @@ static int mtk_hdmi_phy_probe(struct platform_device *pdev)
>         if (!hdmi_phy)
>                 return -ENOMEM;
>
> -       mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       hdmi_phy->regs = devm_ioremap_resource(dev, mem);
> -       if (IS_ERR(hdmi_phy->regs)) {
> +       hdmi_phy->regs = devm_platform_ioremap_resource(pdev, 0);
> +       if (IS_ERR(hdmi_phy->regs))
>                 return PTR_ERR(hdmi_phy->regs);
> -       }
>
>         ref_clk = devm_clk_get(dev, "pll_ref");
>         if (IS_ERR(ref_clk)) {
> --
> 2.18.0
>