linux-kernel - Re: [PATCH v5 00/12] Add OTG mode support to Tegra USB PHY, SMB347 and Nexus 7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f612e599-42ee-f385-b198-bdab95ab890a@gmail.com>
Date:   Fri, 30 Jul 2021 21:30:27 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Sebastian Reichel <sre@...nel.org>,
        David Heidelberg <david@...t.cz>
Cc:     devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, Thierry Reding <treding@...dia.com>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mark Brown <broonie@...nel.org>,
        Peter Chen <peter.chen@...nel.org>,
        Felipe Balbi <balbi@...nel.org>
Subject: Re: [PATCH v5 00/12] Add OTG mode support to Tegra USB PHY, SMB347
 and Nexus 7

30.07.2021 20:37, Dmitry Osipenko пишет:
> 17.07.2021 21:21, Dmitry Osipenko пишет:
> ...
>>   power: supply: smb347-charger: Make smb347_set_writable() IRQ-safe
>>   power: supply: smb347-charger: Utilize generic regmap caching
>>   power: supply: smb347-charger: Implement USB VBUS regulator
> 
> I noticed that charging doesn't work properly now, will fix it in v6.
> 

For the record, it wasn't enough to enable the regmap caching, we also
need to fill up the cache on init by specifying the num_reg_defaults_raw
parameter.

This uncovered another problem where the pin control "enable" bit was
unsettling because the default regmap values were initialized to zeros
and driver doesn't set the enable bit at all.