linux-kernel - [BUG] memstick: rtsx_usb_ms: possible uninitialized-variable access in rtsx_usb_ms_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e49e0ad5-d09d-4fa7-12a9-0608d9c9d800@gmail.com>
Date:   Sat, 31 Jul 2021 14:36:49 +0800
From:   Li Tuo <islituo@...il.com>
To:     maximlevitsky@...il.com, oakad@...oo.com, ulf.hansson@...aro.org
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        baijiaju1990@...il.com
Subject: [BUG] memstick: rtsx_usb_ms: possible uninitialized-variable access
 in rtsx_usb_ms_issue_cmd()

Hello,

Our static analysis tool finds a possible uninitialized-variable access 
in the memstick driver in Linux 5.14.0-rc3:

At the beginning of the function rtsx_usb_ms_issue_cmd(), the variable 
int_reg is not initialized.
If the following condition is true, it remains uninitialized.
469:    if (req->long_data)

However, it is accessed in some statements such as:
491:    if (int_reg & MS_INT_CMDNK)

I am not quite sure whether this possible uninitialized-variable access 
is real and how to fix it if it is real.
Any feedback would be appreciated, thanks!

Reported-by: TOTE Robot <oslab@...nghua.edu.cn>

Best wishes,
Tuo Li