linux-kernel - Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <162771727997.714452.2303764341103276867@swboyd.mtv.corp.google.com>
Date:   Sat, 31 Jul 2021 00:41:19 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Russell King (Oracle) <linux@...linux.org.uk>,
        <u.kleine-koenig@...gutronix.de>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Claudiu.Beznea@...rochip.com, alexandre.belloni@...tlin.com,
        linux-kernel@...r.kernel.org, thierry.reding@...il.com,
        lee.jones@...aro.org, linux-clk@...r.kernel.org,
        linux-rtc@...r.kernel.org, Ludovic.Desroches@...rochip.com,
        o.rempel@...gutronix.de, andy.shevchenko@...il.com,
        aardelean@...iqon.com, linux-pwm@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, broonie@...nel.org,
        Jonathan.Cameron@...wei.com, linux-arm-kernel@...ts.infradead.org,
        a.zummo@...ertech.it, linux-spi@...r.kernel.org, wsa@...nel.org,
        kernel@...gutronix.de, akpm@...ux-foundation.org,
        torvalds@...ux-foundation.org
Subject: Re: About clk maintainership [Was: Re: [PULL] Add variants of devm_clk_get for prepared and enabled clocks enabled clocks]

Quoting Russell King (Oracle) (2021-07-28 13:40:34)
> > I adapted the Subject in the hope to catch Stephen's and Michael's
> > attention. My impression is that this thread isn't on their radar yet,
> > but the topic here seems important enough to get a matching Subject.

The thread is on my radar but...

> 
> Have you thought about sending your pull request to the clk API
> maintainer (iow, me) ?
> 

+1 This patch doesn't fall under CCF maintainer.

 $ ./scripts/get_maintainer.pl -f include/linux/clk.h
 Russell King <linux@...linux.org.uk> (maintainer:CLK API)
 linux-clk@...r.kernel.org (open list:CLK API)
 linux-kernel@...r.kernel.org (open list)

Finally, this sort of patch has been discussed for years and I didn't
see any mention of those previous attempts in the patch series. Has
something changed since that time? I think we've got a bunch of hand
rolled devm things in the meantime but not much else. 

I still wonder if it would be better if we had some sort of DT binding
that said "turn this clk on when the driver probes this device and keep
it on until the driver is unbound". That would probably work well for
quite a few drivers that don't want to ever call clk_get() or
clk_prepare_enable() and could tie into the assigned-clock-rates
property in a way that let us keep the platform details out of the
drivers. We could also go one step further and make a clk pm domain when
this new property is present and then have the clk be enabled based on
runtime PM of the device (and if runtime PM is disabled then just enable
it at driver probe time).