linux-kernel - Re: [PATCH] clk: fix leak on devm_clk_bulk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <162771802186.714452.5743429710136064714@swboyd.mtv.corp.google.com>
Date:   Sat, 31 Jul 2021 00:53:41 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Brian Norris <briannorris@...omium.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>,
        Dong Aisheng <aisheng.dong@....com>, stable@...r.kernel.org
Subject: Re: [PATCH] clk: fix leak on devm_clk_bulk_get_all() unwind

Quoting Brian Norris (2021-07-30 19:59:50)
> clk_bulk_get_all() allocates an array of struct clk_bulk data for us
> (unlike clk_bulk_get()), so we need to free it. Let's use the
> clk_bulk_put_all() helper.
> 
> kmemleak complains, on an RK3399 Gru/Kevin system:
> 
> unreferenced object 0xffffff80045def00 (size 128):
>   comm "swapper/0", pid 1, jiffies 4294667682 (age 86.394s)
>   hex dump (first 32 bytes):
>     44 32 60 fe fe ff ff ff 00 00 00 00 00 00 00 00  D2`.............
>     48 32 60 fe fe ff ff ff 00 00 00 00 00 00 00 00  H2`.............
>   backtrace:
>     [<00000000742860d6>] __kmalloc+0x22c/0x39c
>     [<00000000b0493f2c>] clk_bulk_get_all+0x64/0x188
>     [<00000000325f5900>] devm_clk_bulk_get_all+0x58/0xa8
>     [<00000000175b9bc5>] dwc3_probe+0x8ac/0xb5c
>     [<000000009169e2f9>] platform_drv_probe+0x9c/0xbc
>     [<000000005c51e2ee>] really_probe+0x13c/0x378
>     [<00000000c47b1f24>] driver_probe_device+0x84/0xc0
>     [<00000000f870fcfb>] __device_attach_driver+0x94/0xb0
>     [<000000004d1b92ae>] bus_for_each_drv+0x8c/0xd8
>     [<00000000481d60c3>] __device_attach+0xc4/0x150
>     [<00000000a163bd36>] device_initial_probe+0x1c/0x28
>     [<00000000accb6bad>] bus_probe_device+0x3c/0x9c
>     [<000000001a199f89>] device_add+0x218/0x3cc
>     [<000000001bd84952>] of_device_add+0x40/0x50
>     [<000000009c658c29>] of_platform_device_create_pdata+0xac/0x100
>     [<0000000021c69ba4>] of_platform_bus_create+0x190/0x224
> 
> Fixes: f08c2e2865f6 ("clk: add managed version of clk_bulk_get_all")
> Cc: Dong Aisheng <aisheng.dong@....com>
> Cc: stable@...r.kernel.org
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---

Applied to clk-fixes