linux-kernel - Re: [PATCH v2 1/2] mwifiex: pcie: add DMI-based quirk implementation for Surface devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 31 Jul 2021 11:50:29 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Jonas Dreßler <verdre@...d.nl>
Cc:     Amitkumar Karwar <amitkarwar@...il.com>,
        Ganapathi Bhat <ganapathi.bhat@....com>,
        Xinming Hu <huxinming820@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Tsuchiya Yuto <kitakar@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        Maximilian Luz <luzmaximilian@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH v2 1/2] mwifiex: pcie: add DMI-based quirk implementation for Surface devices

Jonas Dreßler <verdre@...d.nl> writes:

> This commit adds the ability to apply device-specific quirks to the
> mwifiex driver. It uses DMI matching similar to the quirks brcmfmac uses
> with dmi.c. We'll add identifiers to match various MS Surface devices,
> which this is primarily meant for, later.
>
> This commit is a slightly modified version of a previous patch sent in
> by Tsuchiya Yuto.
>
> Co-developed-by: Tsuchiya Yuto <kitakar@...il.com>
> Signed-off-by: Tsuchiya Yuto <kitakar@...il.com>
> Signed-off-by: Jonas Dreßler <verdre@...d.nl>

[...]

> --- /dev/null
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie_quirks.c
> @@ -0,0 +1,32 @@
> +// SPDX-License-Identifier: GPL-2.0

I prefer having a consistent license within a driver. So please either
convert mwifiex to use SPDX in every file or use the same license boiler
plate as used in the driver.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches