linux-kernel - Re: [PATCH v3 RESEND] x86/tools: fix objdump version check again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Jul 2021 09:17:18 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v3 RESEND] x86/tools: fix objdump version check again

On Fri, 30 Jul 2021 17:01:46 -0700
Randy Dunlap <rdunlap@...radead.org> wrote:

> Skip (omit) any version string info that is parenthesized.
> 
> Warning: objdump version 15) is older than 2.19
> Warning: Skipping posttest.
> 
> where 'objdump -v' says:
> GNU objdump (GNU Binutils; SUSE Linux Enterprise 15) 2.35.1.20201123-7.18

Looks good to me.

Reviewed-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you,


> 
> Fixes: 8bee738bb1979 ("x86: Fix objdump version check in chkobjdump.awk for different formats.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: Borislav Petkov <bp@...en8.de>
> ---
> v3: rebase & resend
>     correct Ingo's email address (not @elte.hu)
>     add x86@...nel.org email address
>     add BP's email address
> 
>  arch/x86/tools/chkobjdump.awk |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210715.orig/arch/x86/tools/chkobjdump.awk
> +++ linux-next-20210715/arch/x86/tools/chkobjdump.awk
> @@ -10,6 +10,7 @@ BEGIN {
>  
>  /^GNU objdump/ {
>  	verstr = ""
> +	gsub(/\(.*\)/, "");
>  	for (i = 3; i <= NF; i++)
>  		if (match($(i), "^[0-9]")) {
>  			verstr = $(i);


-- 
Masami Hiramatsu <mhiramat@...nel.org>