linux-kernel - Re: [patch 03/63] sched: Prepare for RT sleeping spin/rwlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1fde6625113e7099ddc68f291984b8bedf5e387.camel@gmx.de>
Date:   Sun, 01 Aug 2021 17:30:06 +0200
From:   Mike Galbraith <efault@....de>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Will Deacon <will@...nel.org>,
        Waiman Long <longman@...hat.com>,
        Boqun Feng <boqun.feng@...il.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Davidlohr Bueso <dave@...olabs.net>
Subject: Re: [patch 03/63] sched: Prepare for RT sleeping spin/rwlocks

On Fri, 2021-07-30 at 15:50 +0200, Thomas Gleixner wrote:
> 
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -155,6 +155,27 @@ struct task_group;
>                 WRITE_ONCE(current->__state, (state_value));            \
>                 raw_spin_unlock_irqrestore(&current->pi_lock, flags);   \
>         } while (0)
> +
> +
> +#define current_save_and_set_rtlock_wait_state()                       \
> +       do {                                                            \
> +               raw_spin_lock(&current->pi_lock);                       \
> +               current->saved_state = current->__state;                \
                                         ^^should that be using READ_ONCE()?

> +#define current_save_and_set_rtlock_wait_state()                       \
> +       do {                                                            \
> +               raw_spin_lock(&current->pi_lock);                       \
> +               current->saved_state = current->__state;                \
                                         ^^ditto?